Prefer system check which result in a new recipe should be treated as normal packages#919
Merged
ktf merged 2 commits intoalisw:masterfrom Apr 14, 2025
Merged
Prefer system check which result in a new recipe should be treated as normal packages#919ktf merged 2 commits intoalisw:masterfrom
ktf merged 2 commits intoalisw:masterfrom
Conversation
Member
Author
|
@davidrohr this is what we disucssed. |
… normal packages In general when are remote store is provided, we disable system packages. However, this should not be the case if the system package results in a new recipe, because in that case we consider the result of that recipe to be the package.
Member
Author
|
@singiamtel can we have a release with this? |
Collaborator
|
LGTM. New release ongoing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general when are remote store is provided, we disable system packages. However, this
should not be the case if the system package results in a new recipe, because in that case
we consider the result of that recipe to be the package.