Conversation
ktf
reviewed
Apr 15, 2025
ktf
reviewed
Apr 15, 2025
749353b to
5476112
Compare
singiamtel
added a commit
to alisw/ali-bot
that referenced
this pull request
May 5, 2025
Workaround until alisw/alibuild#921 is merged
Member
|
Why does it fail? |
Collaborator
Author
Unrelated to this PR, ongoing fix in #922 |
ktf
pushed a commit
to alisw/ali-bot
that referenced
this pull request
May 5, 2025
Workaround until alisw/alibuild#921 is merged
This way all installations are PEP517 compatible. The setuptools scripts is deprecated, but for now it's the best way of migrating forward. Taking the chance to do this to fix this issue: ``` ERROR: setuptools==53.0.0 is used in combination with setuptools-scm>=8.x Your build configuration is incomplete and previously worked by accident! setuptools-scm requires setuptools>=61 Suggested workaround if applicable: - migrating from the deprecated setup_requires mechanism to pep517/518 and using a pyproject.toml to declare build dependencies which are reliably pre-installed before running the build tools ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way all installations are PEP517 compatible.
The setuptools scripts is deprecated, but for now it's the best way of
migrating forward.
I'll make another PR after in ali-bot to adapt to the new installation method. We can still generate RPMs in a fresh Almalinux:9 docker with the following snippet:
Taking the chance to do this to fix this issue: