Skip to content

Standardize on pyproject.toml#921

Merged
ktf merged 1 commit intomasterfrom
pyproject_only
May 20, 2025
Merged

Standardize on pyproject.toml#921
ktf merged 1 commit intomasterfrom
pyproject_only

Conversation

@singiamtel
Copy link
Copy Markdown
Collaborator

This way all installations are PEP517 compatible.

The setuptools scripts is deprecated, but for now it's the best way of
migrating forward.

I'll make another PR after in ali-bot to adapt to the new installation method. We can still generate RPMs in a fresh Almalinux:9 docker with the following snippet:

yum install -y git
python3 -m ensurepip
python3 -m pip install build pyp2rpm
python3 -m build
pyp2rpm dist/alibuild-1.17.17.tar.gz

Taking the chance to do this to fix this issue:

ERROR: setuptools==53.0.0 is used in combination with setuptools-scm>=8.x

Your build configuration is incomplete and previously worked by accident!
setuptools-scm requires setuptools>=61

Suggested workaround if applicable:
 - migrating from the deprecated setup_requires mechanism to pep517/518
   and using a pyproject.toml to declare build dependencies
   which are reliably pre-installed before running the build tools

singiamtel added a commit to alisw/ali-bot that referenced this pull request May 5, 2025
Workaround until alisw/alibuild#921 is merged
@ktf
Copy link
Copy Markdown
Member

ktf commented May 5, 2025

Why does it fail?

@singiamtel
Copy link
Copy Markdown
Collaborator Author

Why does it fail?

Unrelated to this PR, ongoing fix in #922

ktf pushed a commit to alisw/ali-bot that referenced this pull request May 5, 2025
This way all installations are PEP517 compatible.

The setuptools scripts is deprecated, but for now it's the best way of
migrating forward.

Taking the chance to do this to fix this issue:

```
ERROR: setuptools==53.0.0 is used in combination with setuptools-scm>=8.x

Your build configuration is incomplete and previously worked by accident!
setuptools-scm requires setuptools>=61

Suggested workaround if applicable:
 - migrating from the deprecated setup_requires mechanism to pep517/518
   and using a pyproject.toml to declare build dependencies
   which are reliably pre-installed before running the build tools
```
@ktf ktf merged commit 80943d8 into master May 20, 2025
10 checks passed
@ktf ktf deleted the pyproject_only branch May 20, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants