Skip to content

Conversation

@JimMadge
Copy link
Member

@JimMadge JimMadge commented Oct 9, 2025

Closes #947

  • Add basic Neflify configuration, to fix Netlify build
  • Set Node version to 22 LTS (which may be the latest supported by Netlify, or at least the latest pre-installed).

What is solved here,

  • Deploy to Netlify
  • Build previews

What is not solved here,

  • Using our domain for the Netlify-hosted site (we need to change DNS rules)
  • Redirects (we need to get the translations building then add the rules to netlify.toml)

@netlify
Copy link

netlify bot commented Oct 9, 2025

Deploy Preview for all-contributors ready!

Name Link
🔨 Latest commit 73607b7
🔍 Latest deploy log https://app.netlify.com/projects/all-contributors/deploys/68e7b460a639410008b1261d
😎 Deploy Preview https://deploy-preview-948--all-contributors.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@JimMadge
Copy link
Member Author

JimMadge commented Oct 9, 2025

I forgot to use the angular commit convention 🤦

Sorry @lwasser 😅

@lwasser lwasser merged commit 83587ce into all-contributors:main Oct 9, 2025
7 checks passed
@da5nsy
Copy link
Member

da5nsy commented Oct 9, 2025

Maybe this was clear to others but it wasn't to me so noting here: It looks like the netlify preview is being built via the old Netlify team, not the new one (previews to the new one should be at deploy-preview-123--all-contributors.netlify.app)
This is wrong. I was misunderstanding.

@da5nsy
Copy link
Member

da5nsy commented Oct 9, 2025

The merge doesn't seem to have triggered a build.
The latest build is the deploy preview:
image

Edit: OK, it has built now! 🎉
It must've just taken a while to trigger for some reason 🤷
image

@lwasser
Copy link
Member

lwasser commented Oct 20, 2025

YAY!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(deployment): setup netlify for deployment

3 participants