Feature: tag message from config (#453)#1006
Open
ebAtUelzener wants to merge 2 commits intoallegro:mainfrom
Open
Feature: tag message from config (#453)#1006ebAtUelzener wants to merge 2 commits intoallegro:mainfrom
ebAtUelzener wants to merge 2 commits intoallegro:mainfrom
Conversation
4ddd9a6 to
cdac69a
Compare
cdac69a to
f7fa54a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a way to set the tag message via a callback.
It does not change default behaviour of the plugin.
The explicit suggestion from the original issue (relaying the commit message) is not intended to be implemented by this, however it is possible to provide extra information from CI using e.g. Gradle properties/ environment variables and reading these to set the message.
Minimal example reading an environment variable:
scmVersion { tag { messageCreator { position, version, previousVersion -> val envVar = System.getenv("SOME_VAR") "This is a message on version $version (previous: $previousVersion) {commit: ${position.shortRevision}} [$envVar]" } } }This would allow users to use arbitrary logic to set a tag message, without changing too much of the plugin's internals.