Toggle sharing single scene or entire collection#499
Open
frasercl wants to merge 12 commits intofix/share-large-collectionfrom
Open
Toggle sharing single scene or entire collection#499frasercl wants to merge 12 commits intofix/share-large-collectionfrom
frasercl wants to merge 12 commits intofix/share-large-collectionfrom
Conversation
frasercl
requested review from
ascibisz and
toloudis
and removed request for
a team
|
toloudis
approved these changes
Apr 3, 2026
Contributor
toloudis
left a comment
toloudis
left a comment
There was a problem hiding this comment.
A couple of recommendations (a comment and a symbolic constant) but overall LGTM.
| view3dRef?: React.RefObject<View3d | null>; | ||
| }; | ||
|
|
||
| const MAX_URL_CHARACTERS = 2000; |
Contributor
There was a problem hiding this comment.
just curious, what was the rationale for choosing this number? A comment would be helpful. Because why not 4000 or 32767?
Contributor
Author
There was a problem hiding this comment.
I can put this in a comment!
| const serializedUrl = hasTooManyScenes | ||
| ? encodeSceneUrl(urls[viewerSettings.scene]) | ||
| : urls.map(encodeSceneUrl).join("+"); | ||
| const serializedUrl = showAllScenes ? urls.map(encodeSceneUrl).join("+") : encodeSceneUrl(urls[viewerSettings.scene]); |
Contributor
There was a problem hiding this comment.
I feel like "+" could be a symbolic constant called something like SCENE_DELIMITER since it probably shows up in a couple different places, in other parts of the code.
| } | ||
|
|
||
| // location.pathname will include up to `.../viewer` | ||
| const baseUrl = location.protocol + "//" + location.host + location.pathname; |
Contributor
There was a problem hiding this comment.
surprised there isn't a common function to do this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review time: smallish (~10-15min)
Loosens up the share modal's restrictions on trying to share very large scene collections and image metadata from BFF. This behavior was introduced in #488.
There are two types of data that can be passed to Vol-E from BFF which cause problems for shareable links:
In #488 I added a restriction around 1. and introduced a warning message when either was present. I talked to UX about this, and we agreed to some revisions:
Screenshots
Before
After
