Merged
Conversation
bacb5bc to
c5ebed5
Compare
c5ebed5 to
9502370
Compare
AmberRose2
approved these changes
May 8, 2025
Collaborator
AmberRose2
left a comment
There was a problem hiding this comment.
Looks good, thank you! I think this also makes it a lot clearer for users!
f672ad7 to
c45c522
Compare
c45c522 to
53a56b9
Compare
Collaborator
Author
|
It turned out that HF wasn't reading from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves an encountered problem where some scored data was set to a default value (number of tokens = 0), the field was dropped during serialization (due to
exclude_defaults=Trueinmodel_dump_json), the HuggingFace dataset inferred a null value, and de-serialization in the leaderboard app failed (the number of tokens field expected an int).This PR
dataset_infos.json) which after being uploaded to the root of the results HuggingFace repo should obviate the need for HuggingFace schema inference.