Conversation
|
For reference, this is where it used to be: |
|
Note: I rebuilt my docker env (using --no-cache) and still see stuff like vs Maybe the first one is the latest thing? |
| path_in_repo="README.md", | ||
| repo_id=repo_id, | ||
| commit_message=comment, | ||
| repo_type="dataset", |
There was a problem hiding this comment.
Got a 404 without this.
rodneykinney
left a comment
There was a problem hiding this comment.
Hmmm. I think for the maximum consistency we should have sorted keys, and run update_readme with the latest version of datasets. It might change the current README, but it should be functionally the same
|
Sounds good I'll take out the sorting=False! I think there's another small bug with a new line but I think I'm close to getting it... |
| configs.append(config_def) | ||
| yaml_section = yaml.dump({"configs": configs}) | ||
| return f"---\n{yaml_section.strip()}\n---{self.text_content.lstrip()}" | ||
| return f"---\n{yaml_section.strip()}\n---\n{self.text_content.lstrip()}" |
There was a problem hiding this comment.
Without this I got
No YAML front matter found in README.md
the next time I ran something that tried to do the readme check, after making my initial change to add a new config.
|
The commit after I uploaded stuff without sorted_keys=False |
|
Published new version. |

snippet from the current README:
if you do dry-run to update the readme without this change
if you do dry-run to update the readme with this change
Now that I know what's happening, it's less confusing, but might be nice to keep the old sorting for minimal diffs?
(note I do see a list vs sequence thing too but I think you said that's just packages being out of date)