Conversation
jbragg
approved these changes
Aug 22, 2025
Collaborator
jbragg
left a comment
There was a problem hiding this comment.
Ofc like Mike I do want fixed behavior during scoring
Collaborator
Author
|
summary stats from test run: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/allenai/astabench-issues/issues/391. Builds on #63, #66.
I was wrong about this (I thought I'd tested with this commit, but looks like CI_tests didn't run for that, and I missed it).
CI_test does seem to pass for this, which is the range in this PR too.
Why does this work when pinning doesn't?
So I think there are two different, incompatible, litellm requirements, but they are not in the core requirements of asta-bench. sqa wants
1.68.0like @mdarcy220 remembered, and futurehouse wants1.67.4.post1. AFAICT we build separate images off an image that has the core requirements for sqa and futurehouse (so we want to be able to build either, but we aren't trying to install both sets of requirements at the same time). So I think that's why the range works and the pinning doesn't... So this PR shifts to @jbragg 's preference of using a range.