Merged
Conversation
mtblanton
commented
Apr 3, 2025
|
|
||
| # We handle the first chunk differently since we want to timeout if it takes longer than 5 seconds | ||
| first_chunk = results.get(5.0) | ||
| first_chunk = results.get(15.0) |
Contributor
Author
There was a problem hiding this comment.
This is the real change, the rest is ruff formatting.
mtblanton
added a commit
that referenced
this pull request
Jun 13, 2025
Based on discussion from Slack: https://allenai.slack.com/archives/C07530Y79Q9/p1743707972179919?thread_ts=1743706445.356419&cid=C07530Y79Q9 The timeout we set for the Tulu3 405B release was a little too short for all models. This was causing Molmo to get "overloaded" errors when it shouldn't have. @codeviking said that Molmo's TTFT p99 was 10s, so we're going a little above that to play it safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on discussion from Slack: https://allenai.slack.com/archives/C07530Y79Q9/p1743707972179919?thread_ts=1743706445.356419&cid=C07530Y79Q9
The timeout we set for the Tulu3 405B release was a little too short for all models. This was causing Molmo to get "overloaded" errors when it shouldn't have. @codeviking said that Molmo's TTFT p99 was 10s, so we're going a little above that to play it safe.