Skip to content

Remove flask api#567

Merged
mtblanton merged 12 commits intomainfrom
remove-flask-api
Mar 24, 2026
Merged

Remove flask api#567
mtblanton merged 12 commits intomainfrom
remove-flask-api

Conversation

@mtblanton
Copy link
Copy Markdown
Contributor

@mtblanton mtblanton commented Mar 23, 2026

@mtblanton mtblanton self-assigned this Mar 23, 2026
@mtblanton mtblanton marked this pull request as draft March 23, 2026 20:34
@mtblanton mtblanton marked this pull request as ready for review March 23, 2026 20:34
@mtblanton mtblanton marked this pull request as draft March 23, 2026 20:37
@mtblanton mtblanton marked this pull request as ready for review March 23, 2026 20:37
1. Generate a local `config.json` file:

```
./bin/bootstrap
Copy link
Copy Markdown
Contributor

@bronzle bronzle Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also ran, which is still needed to bootstrap the app:

kubectl get secret/cfg --namespace olmo-api --output jsonpath="{.data.service_account\.json}" | base64 -D > "$dir/../service_account.json"
echo "wrote \"$dir/../service_account.json\""

kubectl get secret/modal --namespace olmo-api --output jsonpath="{.data.\.modal\.toml}" | base64 -D > "$dir/../.modal.toml"
echo "wrote \"$dir/../.modal.toml\""

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, mb. i'll put this back!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont mind putting this into a just init or straight into the readme, pointing out that part of it was relevant even to fastapi setup

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted bootstrap without looking at it too hard because I thought it was still just loading config.json! This is good enough to bring back.

@mtblanton mtblanton marked this pull request as draft March 23, 2026 20:47
@mtblanton mtblanton marked this pull request as ready for review March 23, 2026 20:47
@bronzle
Copy link
Copy Markdown
Contributor

bronzle commented Mar 23, 2026

are the Move into type-checking block because of python 3.14 ?

should we ignore that in this PR and fix in another? with a git-blame-ignore ? or not worth it?

@jonborchardt
Copy link
Copy Markdown
Contributor

when this goes in. im buying everyone a coke!

@mtblanton
Copy link
Copy Markdown
Contributor Author

are the Move into type-checking block because of python 3.14 ?

should we ignore that in this PR and fix in another? with a git-blame-ignore ? or not worth it?

Looking into that. I think it's a Python 3.14 thing but it doesn't seem quite right

@mtblanton
Copy link
Copy Markdown
Contributor Author

are the Move into type-checking block because of python 3.14 ?

should we ignore that in this PR and fix in another? with a git-blame-ignore ? or not worth it?

@bronzle #569

Copy link
Copy Markdown
Contributor

@bronzle bronzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working well, not broken or anything

@mtblanton mtblanton merged commit 14d6ed6 into main Mar 24, 2026
7 checks passed
@mtblanton mtblanton deleted the remove-flask-api branch March 24, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants