Refactor KnowledgeBase constructor#547
Merged
dakinggg merged 2 commits intoallenai:mainfrom Aug 29, 2025
Merged
Conversation
Contributor
Author
|
@dakinggg sorry the previous PR related to refactoring the KB class was so big - I tried to simplify it in this one. I also added some unit tests and extra docs to test new functionality |
dakinggg
reviewed
Aug 25, 2025
Contributor
Author
|
@dakinggg thanks for the second pass. I fixed the issue with the test. This should be ready for merge now. |
dakinggg
approved these changes
Aug 26, 2025
Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the constructor of the
KnowledgeBaseclass to extend it in two ways:Pathobject (in addition to a string)EntityobjectsThis will enable making custom KB objects, such as using Wikidata (as requested in #346) or using biomedical ontologies (as requested in #331)
This PR was originally part of #542, but that PR had too many things going on, so I split out this part to be simpler to review.
Corresponding PR in my fork (for testing purposes, because I can't run CI on the upstream): cthoyt#8