[Hotfix] Workflow detect_changes not working correctly.#388
Merged
Conversation
…age ONLY if there are changes in alliander_core.Dockerfile Signed-off-by: Peter Geurts <peter.geurts@proton.me>
Signed-off-by: Peter Geurts <peter.geurts@proton.me>
geurto
deleted the
387-hotfix-workflow-detect_changes-not-working-correctly
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the bug
detect-changesfails if${{ github.base_ref }}is not populated, i.e. when doing a commit to main.Furthermore, it only builds the alliander_core image if there are changes to alliander_core.Dockerfile. If there are changes to alliander_description/interfaces/utilities, it will build all images EXCEPT alliander_core/cuda.
Fixes: #387
Testing
Explain how you tested your changes.
Documentation
Additional Notes
Any relevant screenshots, logs, or context.