Skip to content

chore: correct image names in Tilt config file#378

Closed
jeronimoalbi wants to merge 1 commit intomainfrom
chore/tilt-image-names
Closed

chore: correct image names in Tilt config file#378
jeronimoalbi wants to merge 1 commit intomainfrom
chore/tilt-image-names

Conversation

@jeronimoalbi
Copy link
Member

Follow-up to #377

This fixes an issue with Tilt failing because of Docker image names.
It seems to work fine when using "-" instead of "_" for the image names.

The change in the names triggers a Docker warning for any of these two names, for example:

Image not used in any Docker Compose config:
    ✕ ditherchat-reader-main
Did you mean…
    - ditherchat_reader-main
    - ditherchat_api-main
    - postgres
Skipping this image build
If this is deliberate, suppress this warning with: update_settings(suppress_unused_image_warnings=["ditherchat-reader-main"])
Successfully loaded Tiltfile (265.501334ms)

So I added the recommended call to Tilt's update_settings() to ignore them.

@netlify
Copy link

netlify bot commented Oct 16, 2025

Deploy Preview for dither-staging ready!

Name Link
🔨 Latest commit 5f59c0c
🔍 Latest deploy log https://app.netlify.com/projects/dither-staging/deploys/68f0c61893cd52000810d088
😎 Deploy Preview https://deploy-preview-378--dither-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jeronimoalbi
Copy link
Member Author

@mazzy89 can you take a look 🙏?

@mazzy89
Copy link

mazzy89 commented Oct 16, 2025

Thank you @jeronimoalbi. I've provided a clearner PR though that tshould help to fix the problem in a leaner way and actually it is the recommended way by Tilt. Please see #379

@ilgooz ilgooz deleted the chore/tilt-image-names branch October 17, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants