fix(reader-main): prevent DoS via malformed action type matching#427
Merged
luciorubeens merged 3 commits intomainfrom Nov 3, 2025
Merged
fix(reader-main): prevent DoS via malformed action type matching#427luciorubeens merged 3 commits intomainfrom
luciorubeens merged 3 commits intomainfrom
Conversation
✅ Deploy Preview for dither-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
alanrsoares
approved these changes
Nov 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a vulnerability where attackers could hang the service by sending messages with "wrong" action names, eg.
dither.PostRemovewould match thePosthandler.So the service hangs because the wrong handler processes the malformed message, fails to parse it, returns RETRY status, and the message gets stuck in an infinite retry loop.
Now it will extract the exact action type using regex instead of checking prefixes in a for loop, ensuring only properly formatted messages are processed.
This PR also fixes smoke tests.