Skip to content

fix: enforce strong secrets for AUTH and JWT in configuration #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alanrsoares merged 2 commits into from
Nov 17, 2025
Merged

fix: enforce strong secrets for AUTH and JWT in configuration #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0c38c5
fix: enforce strong secrets for AUTH and JWT in configuration
alanrsoares Nov 12, 2025
f8b0e5f
fix: add missing JWT to api-main and AUTH to reader-main docker-compose
alanrsoares Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ services:
environment:
PG_URI: 'postgresql://default:password@postgres:5432/postgres'
AUTH: dev
JWT: dev-jwt-secret
ports:
- 3000:3000
healthcheck:
Expand Down
9 changes: 4 additions & 5 deletions packages/api-main/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import crypto from 'node:crypto';
import process from 'node:process';

import dotenv from 'dotenv';
Expand Down Expand Up @@ -33,8 +32,8 @@ export function useConfig(): Config {
}

if (!process.env.JWT) {
console.log(`JWT was not set, defaulting to a randomized byte hex string.`);
process.env.JWT = crypto.randomBytes(128).toString('hex');
console.error(`Failed to specify JWT, no JWT secret provided`);
throw new Error(`JWT must be set to a strong secret`);
}

if (typeof process.env.JWT_STRICTNESS === 'undefined') {
Expand All @@ -50,8 +49,8 @@ export function useConfig(): Config {
config = {
PORT: process.env.PORT ? Number.parseInt(process.env.PORT) : 3000,
PG_URI: process.env.PG_URI,
AUTH: process.env.AUTH ?? 'default',
JWT: process.env.JWT ?? 'default-secret-key',
AUTH: process.env.AUTH as string,
JWT: process.env.JWT as string,
JWT_STRICTNESS: process.env.JWT_STRICTNESS as JWT_STRICTNESS,
DISCORD_WEBHOOK_URL: process.env.DISCORD_WEBHOOK_URL,
};
Expand Down
1 change: 1 addition & 0 deletions packages/reader-main/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,6 @@ services:
BATCH_SIZE: 50
MEMO_PREFIX: dither.
RECEIVER: atone1uq6zjslvsa29cy6uu75y8txnl52mw06j6fzlep
AUTH: dev
# LOG: process.env.LOG === 'true' ? true : false,
command: [pnpm, start]
7 changes: 4 additions & 3 deletions packages/reader-main/src/config/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ export function useConfig(): typeof config {
return config;
}

if (typeof process.env.AUTH === 'undefined') {
console.warn(`AUTH env variable is set to default, ensure you provide an authorization key for reader communication`);
if (!process.env.AUTH || process.env.AUTH === 'default') {
console.error(`Failed to specify AUTH, no authorization secret provided`);
throw new Error(`AUTH must be set to a strong secret`);
}

config = {
Expand All @@ -25,7 +26,7 @@ export function useConfig(): typeof config {
RECEIVER: process.env.RECEIVER,
SENDER: process.env.SENDER,
LOG: process.env.LOG === 'true',
AUTH: process.env.AUTH ?? 'default',
AUTH: process.env.AUTH,

ECLESIA_GRAPHQL_ENDPOINT: process.env.ECLESIA_GRAPHQL_ENDPOINT,
ECLESIA_GRAPHQL_SECRET: process.env.ECLESIA_GRAPHQL_SECRET,
Expand Down