Skip to content

Conversation

@Bbertatum
Copy link
Contributor

When I needed to install goaccess the make step failed because of missing dependencies (maxmind and ncurses), so I added it in README in the style Debian style.
Then I also wish to have every command copy-pastable without removing the "$" or "#" char so I remove it and add it for the real comments.

@Bbertatum
Copy link
Contributor Author

Last commit is there to include last changes from master branch

@Bbertatum Bbertatum closed this May 17, 2024
@Bbertatum Bbertatum reopened this May 17, 2024
@Bbertatum
Copy link
Contributor Author

Last commit is there to include last changes from master branch

$ ./configure --enable-utf8 --enable-geoip=mmdb
$ make
# make install
sudo apt install libncursesw5-dev libmaxminddb-dev
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sudo apt install libncursesw5-dev libmaxminddb-dev

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's best to keep this part distro-agnostic. We can emphasize the dependencies at the bottom, where they're already listed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it's not the "straightforward way" to have all this deps in a table like this because per-distro commands to make things work are written above (and also I missed it... thx to point it out) maybe I missed something else but these deps are not "optional" because without it the software do not compile.
But I also agree with your way to see things. Thx for your beautiful software BTW :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants