Conversation
…concrete types in AnyComponent. Does not work yet. I can't make AnyComponent.encode(to:) work with treeValues. Committing to have a checkpoint as I test another approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change AlloPlace to never actually decode Components to concrete types, and have it store the intermediate representation. Then, the client can choose to decode-- or not-- Components to concrete types.
This should be a nice backwards compatibility too. As long as we only add fields, AlloPlace won't care that the serialization has changed.
This also replaces the wire protocol from BinaryCodable to CBOR. In the future, we might continue onto ASN.1 which PotentCodable supports.
There are probably still some code paths where AnyCodable leaks through in an unexpected way, but everything seems to work that I've found so far, so we can fix those issues along the way.
CustomComponent isn't entirely thought out though. ComponentLists probably needs to be modified to support it in a sane manner.