Open
Conversation
0xferrous
force-pushed
the
push-zqmrlrwsnkqy
branch
4 times, most recently
from
3f697ea to
bcd37f9
Compare
Author
|
yes i have the same compiler panic for fmt as the CI |
0xferrous
force-pushed
the
push-zqmrlrwsnkqy
branch
from
bcd37f9 to
3757c8c
Compare
Author
|
bumping here @mattsse @DaniPopes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Foundry's traces don't decode the Vm's internal types like
Logwhen decodingvm.getRecordedLogs()for instance. And it is because thesol!doesn't generate the internalTypes.Solution
There is a limitation where the structs need to be defined scoped inside the contract and it doesn't support inheritance, etc. but this was enough for me to get the decoding working on foundry traces.
PR Checklist