feat: move alloy-serde to primitives#1074
Open
stevencartavia wants to merge 2 commits intoalloy-rs:mainfrom
Open
feat: move alloy-serde to primitives#1074stevencartavia wants to merge 2 commits intoalloy-rs:mainfrom
stevencartavia wants to merge 2 commits intoalloy-rs:mainfrom
Conversation
mattsse
reviewed
Feb 14, 2026
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
all of this could we some additional bloat, however imo this is okay, but maybe it's worth gating the serde-json support separately, like serde-json feature
wdyt @DaniPopes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
moving
alloy-serdetoalloy-primitivesSolution
Moved
alloy-serdeintoalloy-primitivesas apub mod serdebehind the existing serde feature flag. Source files are unchanged aside from import path adjustments (alloy_primitives:: → crate::) and feature gate fixes needed becausearbitraryandmapare optional in primitives. Addedserde_jsonas an optional dependency gated behind theserdefeature.PR Checklist