refactor(net): use new TransactionBuilder/NetworkTransactionBuilder traits#618
Draft
lean-apple wants to merge 5 commits intoalloy-rs:mainfrom
Draft
refactor(net): use new TransactionBuilder/NetworkTransactionBuilder traits#618lean-apple wants to merge 5 commits intoalloy-rs:mainfrom
TransactionBuilder/NetworkTransactionBuilder traits#618lean-apple wants to merge 5 commits intoalloy-rs:mainfrom
Conversation
lean-apple
requested review from
clabby,
emhane,
mattsse and
refcell
as code owners
Open
3 tasks
emhane
reviewed
Dec 15, 2025
Collaborator
emhane
left a comment
emhane
left a comment
There was a problem hiding this comment.
tbh I think it makes most sense to just leave the TransactionBuilder impl where it is, and that way don't change the dependencies, just update the impl to remove the generic for TransactionBuilder in accordance with pending alloy release
Collaborator
|
marking as draft, when the deps don't point to a git revision we can mark it as ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
To continue alloy-rs/alloy#3331, once alloy-rs/alloy#3344 is released.
Solution
Split previous
TransactionBuilderimpl, and move it to rpc-typesPR Checklist