fix: format and refactor to resolve Pylint warnings #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes Pylint warnings from rule W0718, and the logger still catches errors thrown here.
This fixes a "line too long" message from Pylint.
Sorted imports and ran PyCharm's formatter to fix line length warnings from Pylint.
This abstraction reduces the number of statements and branches in the `createchannel` command.
There doesn't seem to be a need to store the text/voice type in a variable only to use it a few lines later in a very similar conditional.
This line was resulting in: `W0221: Number of parameters was 0 in 'BotBase.on_command_error' and is now 3 in overriding 'GitCordBot.on_command_error' method (arguments-differ)` We're overriding `on_command_error` exactly as described by the d.py documentation and source code, so I'm not sure why Pylint thinks `BotBase.on_command_error` has 0 parameters. Considering this a false positive and disabling it for the line.
This should resolve a lot of import-related warnings during the GitHub Actions run.
This new `requirements-dev.txt` file is then used in the Pylint workflow on GitHub Actions, mainly to resolve errors with not having `setuptools` installed.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Collaborator
|
Thank you very much for your contribution Sir, Welcome to gitcord<3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6. Here's a general list of what I did:
Exceptioncatching inbot.py.createchannelcommand in thegeneralcog to a helper function.createchannelcommand.requirements.txtas it was used but not defined as a dependency.requirements-dev.txtwith Pylint and Setuptools.There are a few additional comments in my commit descriptions to explain my changes, but let me know if you have any other questions or concerns!