Skip to content

Fix #518: resolve GetTestFixture method reliability issues #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
delatrie merged 1 commit into from
Aug 4, 2025
Merged

Fix #518: resolve GetTestFixture method reliability issues #566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 29 additions & 27 deletions Allure.NUnit/Core/AllureNUnitHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@ internal void StopTestCase()
: null;


AllureLifecycle.StopTestCase(
testCase =>
AllureLifecycle.StopTestCase(testCase =>
{
testCase.status = status;
testCase.statusDetails = statusDetails;
Expand Down Expand Up @@ -147,9 +146,8 @@ TestResultContainer CreateTestContainer() =>

static bool IsBroken(TestContext.ResultAdapter result) =>
!result.Assertions.Any()
|| result.Assertions.Any(
a => a.Status == AssertionStatus.Error
);
|| result.Assertions.Any(a => a.Status == AssertionStatus.Error
);

static void SetIdentifiers(ITest test, TestResult testResult)
{
Expand Down Expand Up @@ -217,57 +215,61 @@ static IEnumerable<AllureTestCaseAttribute> IterateAllAllureAttribites(ITest tes
static string GetNamespace(string classFullName)
{
var lastDotIndex = classFullName?.LastIndexOf('.') ?? -1;
return lastDotIndex == -1 ? null : classFullName.Substring(
0,
lastDotIndex
);
return lastDotIndex == -1
? null
: classFullName.Substring(
0,
lastDotIndex
);
}

static string GetClassName(string classFullName)
{
var lastDotIndex = classFullName?.LastIndexOf('.') ?? -1;
return lastDotIndex == -1 ? classFullName : classFullName.Substring(
lastDotIndex + 1
);
return lastDotIndex == -1
? classFullName
: classFullName.Substring(
lastDotIndex + 1
);
}

static TestFixture GetTestFixture(ITest test)
{
var currentTest = test;
var isTestSuite = currentTest.IsSuite;
while (isTestSuite != true)

while (currentTest != null)
{
currentTest = currentTest.Parent;
if (currentTest is ParameterizedMethodSuite)
if (currentTest is TestFixture testFixture)
{
currentTest = currentTest.Parent;
return testFixture;
}
isTestSuite = currentTest.IsSuite;

currentTest = currentTest.Parent;
}

return (TestFixture) currentTest;

throw new InvalidOperationException(
$"Could not find TestFixture in the hierarchy for test: {test.FullName}. " +
$"Test type: {test.GetType().Name}"
);
}

private void UpdateTestDataFromNUnitProperties()
{
foreach (var p in GetTestProperties(PropertyNames.Description))
{
AllureLifecycle.UpdateTestCase(
x => x.description += $"{p}\n"
AllureLifecycle.UpdateTestCase(x => x.description += $"{p}\n"
);
}

foreach (var p in GetTestProperties(PropertyNames.Author))
{
AllureLifecycle.UpdateTestCase(
x => x.labels.Add(Label.Owner(p))
AllureLifecycle.UpdateTestCase(x => x.labels.Add(Label.Owner(p))
);
}

foreach (var p in GetTestProperties(PropertyNames.Category))
{
AllureLifecycle.UpdateTestCase(
x => x.labels.Add(Label.Tag(p))
AllureLifecycle.UpdateTestCase(x => x.labels.Add(Label.Tag(p))
);
}
}
Expand All @@ -294,7 +296,7 @@ private IEnumerable<string> GetTestProperties(string name)
var list = new List<string>();
var currentTest = _test;
while (currentTest.GetType() != typeof(TestSuite)
&& currentTest.GetType() != typeof(TestAssembly))
&& currentTest.GetType() != typeof(TestAssembly))
{
if (currentTest.Properties.ContainsKey(name))
{
Expand Down
Loading