Skip to content

fix(nunit): properly report ignored test cases #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
delatrie merged 3 commits into from
Aug 5, 2025
Merged

fix(nunit): properly report ignored test cases #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
579020d
chore: add ignore all cases example
delatrie Aug 5, 2025
f0da3ad
chore: fix ignored example with tc source
delatrie Aug 5, 2025
a6740de
fix: report leaves only in AllureDisplayIgnored
delatrie Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions Allure.NUnit.Examples/AllureIgnoredTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ private static IEnumerable Data
{
get
{
yield return new TestCaseData("Ignore").SetName("{m}_NotExist");
yield return new TestCaseData("NotIgnore").SetName("{m}_NotExist ignored").Ignore("Test");
yield return new TestCaseData("NotIgnore").SetName("{m}_NotExist");
yield return new TestCaseData("Ignore").SetName("{m}_NotExist ignored").Ignore("Test");
}
}

Expand All @@ -25,6 +25,14 @@ public void IgnoredTest()
}


[TestCase("a")]
[TestCase("b")]
[Ignore("Foo")]
public void IgnoredTestCase(string data)
{
}


[Test]
[TestCase("a")]
[TestCase("b", Ignore = "Case")]
Expand Down
24 changes: 17 additions & 7 deletions Allure.NUnit/Attributes/AllureDisplayIgnoredAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,7 @@ public void AfterTest(ITest suite)
suite = (TestSuite) suite;
if (suite.HasChildren)
{
var ignoredTests =
GetAllTests(suite).Where(
t => t.RunState == RunState.Ignored
|| t.RunState == RunState.Skipped
);
var ignoredTests = GetIgnoredTests(suite);
foreach (var test in ignoredTests)
{
this.EmitResultForIgnoredTestInTestPlan(test);
Expand All @@ -50,11 +46,25 @@ public void AfterTest(ITest suite)

public ActionTargets Targets => ActionTargets.Suite;

private static IEnumerable<ITest> GetAllTests(ITest test)
static IEnumerable<ITest> GetIgnoredTests(ITest suite, bool parentIgnored = false)
{
return test.Tests.Concat(test.Tests.SelectMany(GetAllTests));
return suite.Tests.SelectMany(test =>
{
bool isIgnored = parentIgnored || IsTestIgnored(test);
return test.IsSuite
? GetIgnoredTests(test, isIgnored)
: isIgnored
? Enumerable.Repeat(test, 1)
: Enumerable.Empty<ITest>();
});
}

static bool IsTestIgnored(ITest test) => test.RunState switch
{
RunState.Ignored or RunState.Skipped => true,
_ => false
};

void EmitResultForIgnoredTestInTestPlan(ITest test)
{
var ignoredTestResult = AllureNUnitHelper.CreateTestResult(test);
Expand Down
Loading