Skip to content

Support for Reqnroll v2.4.1 #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
delatrie merged 1 commit into from
Sep 25, 2025
Merged

Support for Reqnroll v2.4.1 #587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Allure.Reqnroll.Tests.Samples/Allure.Reqnroll.Tests.Samples.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.0" />
<PackageReference Include="Castle.Core" Version="5.1.1" />
<PackageReference Include="Reqnroll" Version="2.0.3" />
<PackageReference Include="Reqnroll.Tools.MsBuild.Generation" Version="2.0.3" />
<PackageReference Include="Reqnroll.xUnit" Version="2.0.3" />
<PackageReference Include="Reqnroll" Version="2.4.1" />
<PackageReference Include="Reqnroll.Tools.MsBuild.Generation" Version="2.4.1" />
<PackageReference Include="Reqnroll.xUnit" Version="2.4.1" />
<PackageReference Include="xunit" Version="2.9.0" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
<PrivateAssets>all</PrivateAssets>
Expand Down
2 changes: 1 addition & 1 deletion Allure.Reqnroll/Allure.Reqnroll.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

<ItemGroup>
<PackageReference Include="CsvHelper" Version="33.0.1" />
<PackageReference Include="Reqnroll" Version="2.0.0" />
<PackageReference Include="Reqnroll" Version="2.4.1" />
<PackageReference Include="System.Collections.Specialized" Version="4.3.0" />
</ItemGroup>

Expand Down
17 changes: 0 additions & 17 deletions Allure.Reqnroll/Events/HookFinishedEventHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ void EnsureFixtureErrorReported(HookFinishedEvent eventData)
if (error is not null)
{
this.ReportHookFailure(eventData);
this.EnsureScenarioReported(eventData);
}
}

Expand Down Expand Up @@ -114,10 +113,6 @@ void EnsureFeatureReported(HookFinishedEvent eventData)
eventData.FeatureContext.FeatureInfo,
eventData.HookException
);

// Reqnroll doesn't fire FeatureFinishedEvent if an AfterFeature
// hook fails. We need to emit feature files here instead.
AllureReqnrollStateFacade.EmitFeatureFiles();
}
}

Expand Down Expand Up @@ -152,18 +147,6 @@ void ReportHookFailure(HookFinishedEvent eventData)
}
}

void EnsureScenarioReported(HookFinishedEvent eventData)
{
if (eventData.HookType is HookType.AfterScenario)
{
// Reqnroll doesn't fire ScenarioFinishedEvent if an AfterScenario
// hook fails. We need to emit scenario files here instead.
AllureReqnrollStateFacade.EmitScenarioFiles(
eventData.ScenarioContext
);
}
}

static bool IsThrownFromHook(StateSnapshot? snapshot, Exception error) =>
snapshot is not null
&& ExceptionFunctions.IsFromHookMethod(error, snapshot.Origin);
Expand Down
Loading