Skip to content

limited prettifying length to 1mb #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CodeGeek32 wants to merge 2 commits into from
Closed

limited prettifying length to 1mb #1156

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f95812
limited prettifying length to 1mb
Apr 15, 2025
5f1837a
limited prettifying length to 1mb
Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions allure-rest-assured/src/main/java/io/qameta/allure/restassured/AllureRestAssured.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
import java.util.TreeSet;

import static io.qameta.allure.attachment.http.HttpRequestAttachment.Builder.create;
import static io.qameta.allure.attachment.http.HttpResponseAttachment.Builder.create;
import static java.util.Optional.ofNullable;

/**
Expand All @@ -45,11 +44,18 @@ public class AllureRestAssured implements OrderedFilter {

private static final String HIDDEN_PLACEHOLDER = "[ BLACKLISTED ]";

private int maxAllowedPrettifyLength = 1048576;

private String requestTemplatePath = "http-request.ftl";
private String responseTemplatePath = "http-response.ftl";
private String requestAttachmentName = "Request";
private String responseAttachmentName;

public AllureRestAssured setMaxAllowedPrettifyLength(final int maxAllowedPrettifyLength) {
this.maxAllowedPrettifyLength = maxAllowedPrettifyLength;
return this;
}

public AllureRestAssured setRequestTemplate(final String templatePath) {
this.requestTemplatePath = templatePath;
return this;
Expand Down Expand Up @@ -123,10 +129,13 @@ public Response filter(final FilterableRequestSpecification requestSpec,
final String attachmentName = ofNullable(responseAttachmentName)
.orElse(response.getStatusLine());

final HttpResponseAttachment responseAttachment = create(attachmentName)
final String responseAsString = response.getBody().asString();
final String body = responseAsString.length() > maxAllowedPrettifyLength ? responseAsString : prettifier.getPrettifiedBodyIfPossible(response, response.getBody());

final HttpResponseAttachment responseAttachment = HttpResponseAttachment.Builder.create(attachmentName)
.setResponseCode(response.getStatusCode())
.setHeaders(toMapConverter(response.getHeaders(), hiddenHeaders))
.setBody(prettifier.getPrettifiedBodyIfPossible(response, response.getBody()))
.setBody(body)
.build();

new DefaultAttachmentProcessor().addAttachment(
Expand Down
Loading