Conversation
github-actions
bot
added
theme:api
epszaw
requested changes
Feb 17, 2026
Member
epszaw
left a comment
epszaw
left a comment
There was a problem hiding this comment.
Good job there! The integrations work correctly in the projects, so there are some moments to fix before we continue
packages/allure-js-commons/src/sdk/reporter/writer/InMemoryWriter.ts
Outdated
Show resolved
Hide resolved
packages/allure-js-commons/src/sdk/reporter/writer/FileSystemWriter.ts
Outdated
Show resolved
Hide resolved
packages/allure-js-commons/src/sdk/reporter/writer/MessageReader.ts
Outdated
Show resolved
Hide resolved
packages/allure-mocha/test/samples/spec/globals/runtimeGlobals.spec.js
Outdated
Show resolved
Hide resolved
delatrie
reviewed
Feb 17, 2026
delatrie
reviewed
Feb 17, 2026
packages/allure-mocha/test/samples/spec/globals/globals.spec.js
Outdated
Show resolved
Hide resolved
formaceft-93
force-pushed
the
global-attach-errors
branch
2 times, most recently
from
35562f4 to
332e9a5
Compare
epszaw
requested changes
Feb 19, 2026
formaceft-93
force-pushed
the
global-attach-errors
branch
from
79165e0 to
754b802
Compare
epszaw
approved these changes
Feb 20, 2026
delatrie
requested changes
Feb 23, 2026
delatrie
requested changes
Feb 23, 2026
delatrie
approved these changes
Feb 24, 2026
Collaborator
delatrie
left a comment
delatrie
left a comment
There was a problem hiding this comment.
There are some tiny hints/suggestions, but otherwise, LGTM. Pls, take a look at the comments before merging.
packages/allure-codeceptjs/test/spec/runtime/modern/globals.test.ts
Outdated
Show resolved
Hide resolved
packages/allure-mocha/test/samples/spec/globals/runtimeGlobalsContexts.spec.js
Outdated
Show resolved
Hide resolved
packages/allure-mocha/test/samples/spec/globals/runtimeGlobalsSetupOnly.spec.js
Outdated
Show resolved
Hide resolved
delatrie
approved these changes
Feb 24, 2026
formaceft-93
force-pushed
the
global-attach-errors
branch
from
46528e3 to
2d451c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Global attachments and global errors feature
Checklist