Skip to content

Conversation

@ivan-neverov-al
Copy link
Contributor

Adding excluded and mode options for Parameter class for Ruby binding

@ivan-neverov-al ivan-neverov-al requested a review from andrcuns as a code owner May 17, 2025 03:08
@CLAassistant
Copy link

CLAassistant commented May 17, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@andrcuns andrcuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivan-neverov-al Thanks, changes look good to me, few minor questions from me.

@ivan-neverov-al ivan-neverov-al requested a review from andrcuns May 19, 2025 19:26
@andrcuns andrcuns added the enhancement Improvement or request label May 19, 2025
@ivan-neverov-al
Copy link
Contributor Author

@andrcuns missed one more rubocop fix

Copy link
Collaborator

@andrcuns andrcuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's much better now, but I think it's better to have explicit constants for each mode as it is more explicit and avoids using plain strings in code, better for future maintainability

@ivan-neverov-al ivan-neverov-al force-pushed the add_excluded_and_mode branch from 8ed36b9 to 1bbc954 Compare May 19, 2025 19:55
@ivan-neverov-al ivan-neverov-al requested a review from andrcuns May 19, 2025 19:56
Copy link
Collaborator

@andrcuns andrcuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing I missed. I think we should not allow to create json with invalid values, it will cause issues downstream I believe

@andrcuns
Copy link
Collaborator

Sorry, some of my suggestions are causing rubocop issues, I don't have an editor with code open right now

@ivan-neverov-al ivan-neverov-al requested a review from andrcuns May 19, 2025 20:32
@ivan-neverov-al ivan-neverov-al force-pushed the add_excluded_and_mode branch from b3d3fbc to 404d994 Compare May 19, 2025 21:29
@ivan-neverov-al
Copy link
Contributor Author

@andrcuns sorry, missed rubocop and one test

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 404d994 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 98.9% (0.0% change).

View more on Code Climate.

@andrcuns andrcuns merged commit 44d90db into allure-framework:master May 20, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants