Skip to content

Bump com.github.spotbugs:spotbugs from 4.8.6 to 4.9.2 #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baev merged 2 commits into from
Mar 5, 2025
Merged

Bump com.github.spotbugs:spotbugs from 4.8.6 to 4.9.2 #2902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1db8a91
Bump com.github.spotbugs:spotbugs from 4.8.6 to 4.9.2
dependabot[bot] Mar 5, 2025
2016ee1
remove spotbugs annotations due to java requirement
baev Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion allure-jira-commons/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ dependencies {
annotationProcessor("org.projectlombok:lombok")
api("com.squareup.retrofit2:converter-jackson")
api("com.squareup.retrofit2:retrofit")
compileOnly("com.github.spotbugs:spotbugs-annotations")
compileOnly("org.projectlombok:lombok")
compileOnly(project(":allure-plugin-api"))
}
2 changes: 0 additions & 2 deletions ...-jira-commons/src/main/java/io/qameta/allure/jira/retrofit/DefaultCallAdapterFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
*/
package io.qameta.allure.jira.retrofit;

import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import okhttp3.ResponseBody;
import retrofit2.Call;
import retrofit2.CallAdapter;
Expand Down Expand Up @@ -88,7 +87,6 @@ public retrofit2.Response<T> adapt(final Call<T> call) {
/**
* Call adapter factory for instances.
*/
@SuppressFBWarnings("NP_NONNULL_RETURN_VIOLATION")
private class InstanceCallAdapter implements CallAdapter<T, Object> {

private static final int NOT_FOUND = 404;
Expand Down
3 changes: 1 addition & 2 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,7 @@ subprojects {
dependencies {
dependency("ch.qos.logback:logback-classic:1.3.15")
dependency("com.beust:jcommander:1.82")
dependency("com.github.spotbugs:spotbugs-annotations:4.8.6")
dependency("com.github.spotbugs:spotbugs:4.8.6")
dependency("com.github.spotbugs:spotbugs:4.9.2")
dependency("com.opencsv:opencsv:5.9")
dependency("com.puppycrawl.tools:checkstyle:10.21.4")
dependency("com.squareup.retrofit2:converter-jackson:${comSquareupRetrofit2Version}")
Expand Down
4 changes: 4 additions & 0 deletions gradle/quality-configs/spotbugs/exclude.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,8 @@
<!-- finalizer methods are pretty much a dead pattern in Java -->
<Bug pattern="CT_CONSTRUCTOR_THROW"/>
</Match>

<Match class="io.qameta.allure.jira.retrofit.DefaultCallAdapterFactory$InstanceCallAdapter">
<Bug pattern="NP_NONNULL_RETURN_VIOLATION"/>
</Match>
</FindBugsFilter>
Loading