Merged
Conversation
todti
added
type:improvement
delatrie
requested changes
Jul 1, 2025
epszaw
requested changes
Jul 2, 2025
|
|
||
| for (const layer of itemGroups) { | ||
| if (layer.length === 0) { | ||
| if (layer?.length === 0) { |
Member
There was a problem hiding this comment.
Better to check !layer?.length because if the length is not available layer?.length equals to undefined and the condition is falsy
todti
force-pushed
the
titlepath-tree
branch
3 times, most recently
from
846994c to
4f2ebba
Compare
epszaw
approved these changes
Jul 8, 2025
| const treeLabels = hasGroupBy | ||
| ? preciseTreeLabels(groupBy, convertedTrs, ({ labels }) => labels.map(({ name }) => name)) | ||
| : []; | ||
| // const treeLabels = preciseTreeLabels( |
delatrie
approved these changes
Jul 8, 2025
| | `theme` | Default color theme of the report | `light \| dark` | OS theme | | ||
| | `reportLanguage` | Default language of the report | `string` | OS language | | ||
| | `ci` | CI data which will be rendered in the report | `{ type: "github" \| "jenkins", url: string, name: string }` | `undefined` | | ||
| | `groupBy` | By default, tests are grouped using the `titlePath` provided by the test framework. | `string`| Grouping by `titlepath` | |
Collaborator
There was a problem hiding this comment.
By default, tests are grouped using the
titlePathprovided by the test framework.
Let's also explain what this parameter does, not only what the default value is.
| const processTestResult = async (visitor: ResultsVisitor, result: Partial<TestResult>, originalFileName: string) => { | ||
| const dest: RawTestResult = { | ||
| uuid: ensureString(result.uuid), | ||
| titlePath: result?.titlePath?.length ? result.titlePath : [], |
Collaborator
There was a problem hiding this comment.
A reminder for me to create an issue for a fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
groupBy