refactor(web-react): standalone Label, merge context without spreading to DOM#2545
Closed
crishpeen wants to merge 1 commit intorefactor/DS-2398-helpertext-standalone-and-aria-idsfrom
Conversation
…ing to DOM #DS-2398
crishpeen
requested review from
a team,
adamkudrna,
dlouhak,
katerinarehorkova,
literat and
pavelklibani
as code owners
✅ Deploy Preview for spirit-design-system-docsite ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
❌ Deploy Preview for spirit-design-system-storybook failed. Why did it fail? →
|
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
crishpeen
changed the base branch from
main
to
refactor/DS-2398-helpertext-standalone-and-aria-ids
dlouhak
reviewed
Mar 17, 2026
Contributor
dlouhak
left a comment
dlouhak
left a comment
There was a problem hiding this comment.
Please, refactor FieldGroup and Item as well.
Member
Author
|
moved to #2547 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracts a standalone
Labelcomponent (fromField) and alignsHelperTextandLabelso context is merged for styling only and never spread onto the DOM. Form-field context (isDisabled,formFieldVariant,isRequired,isLabelHidden,isItem) is read via typeduseContextProps(), merged with defaults and direct props (direct props override context), and only those resolved values are passed to the style hooks; the object passed touseStylePropsis built from defaults + props only, so no context keys reach transfer props or the DOM.Additional context
Field/Labelremoved; newcomponents/LabelwithuseLabelStyleProps, README, tests, figma.PropsProviderwith form-field context and no longer pass label classes from parent style hooks.TextFieldBasestyle hook no longer forwardsisLabelHiddento the input.Issue reference
https://jira.almacareer.tech/browse/DS-2398