fix(web,web-react): dropdown placement default in context and modal placement demo#2553
Merged
crishpeen merged 1 commit intorefactor/DS-2398-react-standalone-form-fieldsfrom Mar 24, 2026
Conversation
crishpeen
requested review from
a team,
adamkudrna,
dlouhak,
katerinarehorkova,
literat and
pavelklibani
as code owners
crishpeen
force-pushed
the
fix/dropdown-placement-context-and-modal-demo
branch
from
ba4a5b6 to
488558d
Compare
Contributor
|
Here is the URL of the uploaded artifact: https://github.com/alma-oss/spirit-design-system/actions/runs/23332330996/artifacts/6021137740 |
dlouhak
reviewed
Mar 20, 2026
Contributor
dlouhak
left a comment
dlouhak
left a comment
There was a problem hiding this comment.
Didn't we miss the placement-* class in the:
- Item README,
- Navigation demo,
- PricingPlan demo,
- SegmentedControl demo + README,
- SplitButton README,
- UNSTABLE_Header demo
?
literat
reviewed
Mar 23, 2026
pavelklibani
approved these changes
Mar 23, 2026
…lacement demo - web-react: resolve placement in useDropdownContext; stop setting data-spirit-placement on popover - web: add placement-bottom-start on modal dropdown popover demo
crishpeen
force-pushed
the
fix/dropdown-placement-context-and-modal-demo
branch
from
488558d to
b4bbd87
Compare
Contributor
|
Here is the URL of the uploaded artifact: https://github.com/alma-oss/spirit-design-system/actions/runs/23479416254/artifacts/6075725891 |
literat
approved these changes
Mar 24, 2026
crishpeen
merged commit 278c5ba
into
refactor/DS-2398-react-standalone-form-fields
27 of 28 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
placementinuseDropdownContextwhen the provider omits it (React context replacescreateContextdefaults, soplacement-bottom-startwas missing on the popover).data-spirit-placementfromuseDropdownPopovercontent props; placement is conveyed viaplacement-*classes only.placement-bottom-startto the modal-with-dropdown demo popover for placement helper SCSS.Additional context
Targets branch
refactor/DS-2398-react-standalone-form-fields.Issue reference
https://jira.almacareer.tech/browse/DS-2398