style(web-react): set lint dependency and remove unrelevant eslint ignores from demo files#2561
Open
style(web-react): set lint dependency and remove unrelevant eslint ignores from demo files#2561
Conversation
✅ Deploy Preview for spirit-design-system-docsite ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
literat
changed the title
literat
commented
Mar 30, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the web-react lint workflow to ensure linting runs with required build artifacts present (notably for icons/tokens subpath exports), and cleans up now-unnecessary ESLint suppression comments across demo entrypoints. It also aligns some workspace lint ignore patterns and dependency catalog usage.
Changes:
- Add an Nx
linttarget for@alma-oss/spirit-web-reactthat depends on building@alma-oss/spirit-iconsand@alma-oss/spirit-design-tokens. - Remove previously-needed
eslint-disable import/extensions, import/no-unresolvedblocks fromweb-reactdemo-related files (andsrc/icons/index.tsx). - Adjust workspace-level lint ignore patterns and normalize
lerna/nxdependency declarations via Yarn catalogs.
Reviewed changes
Copilot reviewed 53 out of 54 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
yarn.lock |
Reflects dependency catalog updates (adds nx and switches lerna reference to catalog). |
package.json |
Switches lerna devDependency to catalog:script to align with Yarn catalogs. |
.yarnrc.yml |
Updates the lerna catalog entry to use the patched lerna@9.0.3 spec; keeps nx cataloged. |
eslint.config.mjs |
Adds apps/docsite to root ESLint ignore list (root eslint ./ runs). |
examples/next-with-app-router/eslint.config.mjs |
Ignores generated next-env.d.ts in the example app ESLint config. |
packages/web-react/project.json |
Adds an Nx lint target that runs ESLint from the package root and depends on icons/tokens builds. |
packages/web-react/package.json |
Adds nx as a devDependency and switches lint script to run via Nx. |
packages/web-react/src/icons/index.tsx |
Removes now-unnecessary ESLint disable comments tied to missing build artifacts. |
packages/web-react/src/components/UNSTABLE_Header/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/UNSTABLE_FileUpload/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/UNSTABLE_Attachment/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Truncate/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Tooltip/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Toggle/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Toast/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Timeline/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/TextField/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/TextArea/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Tag/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/SplitButton/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Spinner/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Slider/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/SkipLink/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Skeleton/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Select/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/SegmentedControl/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/ScrollView/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Radio/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/PricingPlan/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Pagination/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Navigation/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Modal/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Item/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/IconBox/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Icon/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Header/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Footer/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/FileUploader/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/FieldGroup/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Dropdown/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Drawer/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/ControlButton/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Collapse/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Collapse/demo/Collapse.tsx |
Removes now-unnecessary comment about CI dist directory. |
packages/web-react/src/components/Checkbox/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Card/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/ButtonLink/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Button/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Breadcrumbs/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Avatar/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Alert/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Accordion/demo/index.tsx |
Removes now-unnecessary ESLint disable comments. |
packages/web-react/src/components/Accordion/demo/AccordionUncontrolled.tsx |
Removes now-unnecessary comment about CI dist directory. |
packages/web-react/src/components/Accordion/demo/Accordion.tsx |
Removes now-unnecessary comment about CI dist directory. |
Comments suppressed due to low confidence (1)
examples/next-with-app-router/eslint.config.mjs:30
next-env.d.tsis now listed underignores, but this config file also contains a laterfiles: ['next-env.d.ts']override block. Since ignored files are skipped entirely, that override becomes dead code. Consider removing either the ignore entry or the redundant override to keep the config consistent.
'**/build/**',
'**/.next/**',
'**/.coverage/**',
'next-env.d.ts',
// # Highly recommended to re-include JavaScript dotfiles to lint them
// # (This will cause .*rc.js to be linted by ESLint 🤘)
'!.*.js',
…nores from demo files
* resolve the dependencies between tasks using nx * some packages must be built before linting
* using lerna, it breaks the terminal stream, because of mixing lerna and nx commands
literat
force-pushed
the
style/web-react-demo-dist
branch
from
7184854 to
53d792a
Compare
literat
requested review from
a team,
dlouhak,
katerinarehorkova and
pavelklibani
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set up build dependency for web-react linting, so we can get rid of some ESLint ignore comments.
Lerna/Nx will take care of building the required packages before running lint. Uses cache, rebuilds are quick.
Additional context
Issue reference