fix(web): override Heading hover underline on CardLink#2562
Merged
Conversation
crishpeen
requested review from
a team,
adamkudrna,
dlouhak,
katerinarehorkova,
literat and
pavelklibani
as code owners
✅ Deploy Preview for spirit-design-system-docsite ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for spirit-design-system canceled.
|
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
adamkudrna
approved these changes
Mar 31, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review: fix/web-card-link-heading-decoration
Scope: 2 commits, 1 file (+5 / −0)
Overview
- Extends
.CardLink:first-of-typeso:hoverand:activeexplicitly settext-decoration: none, overriding heading link styles fromhelpers/links/_links.scssthat would otherwise show an underline on hover/active when the stretched card link wraps aHeading.
Findings
No issue, todo, suggestion, or chore findings in scope.
Summary
| Category | Count |
|---|---|
| Issues (blocking) | 0 |
| Issues (non-blocking) | 0 |
| Suggestions | 0 |
| Questions | 0 |
| Notes / thoughts | 0 |
Verdict: APPROVE
The change matches how link/heading specificity is layered in this codebase ([class*='typography-heading'] a:hover in _links.scss) and fixes the regression without broadening scope.
praise: Targeted override on the stretched card link only; minimal diff and the right place to fix the Heading + CardLink interaction.
Sent by Cursor Automation: Spirit Cursor Code Review
Contributor
|
Here is the URL of the uploaded artifact: https://github.com/alma-oss/spirit-design-system/actions/runs/23817878783/artifacts/6208365874 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds explicit
&:hoverand&:activerules on.CardLink:first-of-typewithtext-decoration: noneso the stretched card link does not pick up the defaultHeadinghover underline when a heading is nested inside the link.Additional context
Headingstyles apply underline on interaction; becauseCardLinkalready setstext-decoration: nonefor the default state, hover/active needed the same reset so nested headings do not show a stray underline.Issue reference
Link the Jira issue when available (e.g. https://jira.almacareer.tech/browse/DS-XXXX).