Skip to content

fix(web): address review comments in Offcanvas and dynamic color docs#2564

Merged
crishpeen merged 1 commit intofeat/dynamic-color-css-vars-playgroundfrom
cursor/pull-request-comments-458f
Mar 31, 2026
Merged

fix(web): address review comments in Offcanvas and dynamic color docs#2564
crishpeen merged 1 commit intofeat/dynamic-color-css-vars-playgroundfrom
cursor/pull-request-comments-458f

Conversation

@crishpeen
Copy link
Copy Markdown
Member

Description

Addresses open PR review comments by refining Offcanvas modal/non-modal behavior ordering and cleaning up docs/demo markup.

Implemented changes:

  • Offcanvas:
    • unified modal/non-modal branch ordering in show()
    • kept is-non-modal class handling consistent
    • added spacing/readability tweaks around modal conditionals
  • Drawer docs demo:
    • updated heading/button capitalization to Non-modal Drawer
    • removed extra explanatory paragraph per review suggestion
  • Dynamic Color playground/demo:
    • switched controls container from docs-Stack/Grid + FieldGroup wrappers to regular Stack-based fieldset layout
    • applied clearer section legends (typography-body-medium-semibold mb-900)
    • used Stack--hasIntermediateDividers for section separation
    • renamed legend to Common Formula (advanced)
    • changed reset button to type="reset" and moved reset syncing to form reset handler
    • changed static border showcase from <button> to <div> blocks

Validation performed:

  • corepack yarn prettier --check on changed files
  • corepack yarn workspace @alma-oss/spirit-web lint
  • corepack yarn workspace @alma-oss/spirit-design-tokens build
  • corepack yarn workspace @alma-oss/spirit-web test:unit -- Offcanvas.test.ts

Additional context

  • This branch is layered on top of feat/dynamic-color-css-vars-playground and focuses specifically on review follow-ups.

Issue reference

Open in Web Open in Cursor 

Co-authored-by: Jan Kryšpín <crishpeen@gmail.com>
@crishpeen crishpeen marked this pull request as ready for review March 31, 2026 20:26
@crishpeen crishpeen merged commit 6b5aa46 into feat/dynamic-color-css-vars-playground Mar 31, 2026
29 checks passed
@crishpeen crishpeen deleted the cursor/pull-request-comments-458f branch March 31, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants