fix(web): address review comments in Offcanvas and dynamic color docs#2564
Merged
crishpeen merged 1 commit intofeat/dynamic-color-css-vars-playgroundfrom Mar 31, 2026
Conversation
Co-authored-by: Jan Kryšpín <crishpeen@gmail.com>
6b5aa46
into
feat/dynamic-color-css-vars-playground
29 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses open PR review comments by refining
Offcanvasmodal/non-modal behavior ordering and cleaning up docs/demo markup.Implemented changes:
Offcanvas:show()is-non-modalclass handling consistentDrawerdocs demo:Non-modal Drawerdocs-Stack/Grid+FieldGroupwrappers to regularStack-based fieldset layouttypography-body-medium-semibold mb-900)Stack--hasIntermediateDividersfor section separationCommon Formula (advanced)type="reset"and moved reset syncing to formresethandler<button>to<div>blocksValidation performed:
corepack yarn prettier --checkon changed filescorepack yarn workspace @alma-oss/spirit-web lintcorepack yarn workspace @alma-oss/spirit-design-tokens buildcorepack yarn workspace @alma-oss/spirit-web test:unit -- Offcanvas.test.tsAdditional context
feat/dynamic-color-css-vars-playgroundand focuses specifically on review follow-ups.Issue reference