Update aloha-ui-links.js #1389
Open
Update aloha-ui-links.js #1389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the href property is editable in firefox if the link text is selected, however when a link is clicked using aloha-ui-links.js the text is not highlighted. i modifed the open function in aloha.ui-links.js
Contributor
|
Can one of the admins verify this patch? |
Author
|
any progress on this? |
Contributor
|
Hi zyphersworld, due licensing we can only accept PR from users that have signed the CLA. https://github.com/alohaeditor/Aloha-Editor/blob/dev/CONTRIBUTING.md |
Author
|
Hi Jotschi, i have signed and sent the CLA a while ago and had confirmation that it was received. |
Contributor
|
@zyphersworld @petrosalema will look into this. |
Contributor
|
Can one of the admins verify this patch? |
1 similar comment
Contributor
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the href property is editable in firefox if the link text is selected, however when a link is clicked using aloha-ui-links.js the text is not highlighted.
i modifed the open function in aloha.ui-links.js