Skip to content

Fix for #1319 - html is pasted in reverse order #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ianchadwick wants to merge 1 commit into
base: howling-mad
Choose a base branch
from
Open

Fix for #1319 - html is pasted in reverse order #1488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 4 additions & 24 deletions src/paste.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,38 +133,18 @@ define([
end : boundaries[1]
});
var loc = Zip.go(zip.loc, zip.markers.start);
nodes.forEach(function (child) {

// reverse the new nodes as we're inserting them at the beginning of the right hand content each time
nodes.reverse().map(function (child) {
loc = Zip.split(loc, function (loc) {
return Content.allowsNesting(Zip.after(loc).name(), child.nodeName);
});
loc = Zip.insert(loc, Boromir(child));
});

var markers = Zip.update(loc);

return [markers.start, markers.end];

var result = MutationTrees.update(tree);
boundaries = result[1].map(Fn.partial(Paths.toBoundary, result[0].domNode()));

var last = Arrays.last(nodes);
var next = Boundaries.nodeAfter(boundaries[1]);

// Because we want to remove the unintentional line added at the end of
// the pasted content
if (next && ('P' === last.nodeName || 'DIV' === last.nodeName)) {
if (Html.hasInlineStyle(next)) {
boundaries[1] = Boundaries.fromEndOfNode(last);
// Move the next inline nodes into the last element
Dom.move(Dom.nodeAndNextSiblings(next, Html.hasLinebreakingStyle), last);
} else if (!Html.isVoidType(next) && !Html.isGroupContainer(next)) {
// Move the children of the last element into the beginning of
// the next block element
boundaries[1] = Dom.children(last).reduce(moveBeforeBoundary, Boundaries.create(next, 0));
Dom.remove(last);
}
}

return boundaries;
}

/**
Expand Down