added new device "Pixel 4" #195
Conversation
| sonyXperia1II, | ||
| smallPhone, | ||
| mediumPhone, | ||
| p4, |
There was a problem hiding this comment.
Why not rename p4 to pixel4? Look at the other names such as sonyXperia1II. Follow the same naming convention.
upstreetcoding
left a comment
upstreetcoding
left a comment
There was a problem hiding this comment.
Your PR has a few issues:
Your PR suggests that you're adding the Pixel 4 device, but you commit these files too. Leave these out:
device_frame/lib/src/devices/ios/iphone_12/device.dart
device_frame/example/ios/Runner/Info.plist
device_frame/example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme
device_frame/example/ios/Runner.xcodeproj/project.pbxproj
.vscode/launch.json
If you're new with PR's its understandable. You should create a seperate branch, based on aloisdeniel:master, and only commit changes that your PR is about.
Second, from looking at your PR, there is no device frame for the Pixel 4 added. You're just using a generic frame and changed the values to match that of the Pixel 4. I dont see much value in this PR because everyone can create a custom device with DeviceInfo.genericPhone()
2 participants
No description provided.