Extend the calendar day with session and settlement info#268
Open
Extend the calendar day with session and settlement info#268
Conversation
gnvk
changed the title
neal
reviewed
Dec 6, 2023
Comment on lines
+181
to
+182
| SessionOpen string `json:"session_open"` | ||
| SessionClose string `json:"session_close"` |
Member
There was a problem hiding this comment.
I wouldn't like to add the session open/close fields here as they were exposed to the API unintentionally and there is no good use for them either as they don't really mean much as far as trading goes.
We can't remove it from the API response as that would be a breaking change, but at least we avoid adding it here to avoid more breaking changes in future.
Collaborator
Author
There was a problem hiding this comment.
Can you please add this comment to the original issue: #266?
Contributor
|
@gnvk can we close this PR? |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #266