Open
Conversation
gnvk
reviewed
Mar 18, 2025
gnvk
reviewed
Mar 18, 2025
gnvk
reviewed
Mar 18, 2025
gnvk
reviewed
Mar 18, 2025
gnvk
requested changes
Mar 18, 2025
Collaborator
gnvk
left a comment
gnvk
left a comment
There was a problem hiding this comment.
The following code will fail against the real server:
codes, err := marketdata.GetExchangeCodes()
if err != nil {
panic(err)
}panic: failed to unmarshal news: invalid character '\x1f' looking for beginning of value
gnvk
reviewed
Mar 19, 2025
marketdata/rest.go
Outdated
|
|
||
| defer resp.Body.Close() | ||
|
|
||
| var exchangeCodes map[string]string |
Collaborator
There was a problem hiding this comment.
[minor] I prefer declaring this just before usage (L1593).
gnvk
approved these changes
Mar 19, 2025
Collaborator
gnvk
left a comment
gnvk
left a comment
There was a problem hiding this comment.
LGTM. Thank you for your contribution!
Author
Thank you for the review! |
Author
|
On a side note, these linting errors are unrelated to the changes in this PR. EDIT: I remembered about #331 which should fix them already, so I'll wait for that and rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #286