Skip to content

Consolidate logic for building query requests, other basic code cleanups#52

Open
briancappello wants to merge 4 commits intoalpacahq:masterfrom
briancappello:code-cleanup
Open

Consolidate logic for building query requests, other basic code cleanups#52
briancappello wants to merge 4 commits intoalpacahq:masterfrom
briancappello:code-cleanup

Conversation

@briancappello
Copy link
Contributor

@briancappello briancappello commented Aug 8, 2020

  • moved the logic for building query requests into the Params class
  • consolidated get_timestamp and is_iterable into a utils module
  • cleaned up the imports

briancappello
briancappello commented Aug 8, 2020
View reviewed changes
briancappello
briancappello commented Aug 8, 2020
View reviewed changes
briancappello
briancappello commented Aug 8, 2020
View reviewed changes
briancappello
briancappello commented Aug 8, 2020
View reviewed changes
@dakimura
Copy link
Contributor

dakimura commented Aug 8, 2020

Thank you for the nice refactor, LGTM

@briancappello briancappello mentioned this pull request Aug 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dakimura dakimura dakimura approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@briancappello @dakimura