Check if glob contains wildcards #800
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit add an explicit check to see if a `glob` CWL option actually contains a wildcard (and needs to be resolved against the filesystem on the destination location) or if it is just a plain string (and only needs to check for existence in the target location).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #800 +/- ##
==========================================
+ Coverage 72.60% 72.72% +0.11%
==========================================
Files 90 90
Lines 11904 11943 +39
Branches 2097 2110 +13
==========================================
+ Hits 8643 8685 +42
+ Misses 2771 2765 -6
- Partials 490 493 +3 ☔ View full report in Codecov by Sentry. |
GlassOfWhiskey
force-pushed
the
master
branch
7 times, most recently
from
b21f362 to
e7820f1
Compare
GlassOfWhiskey
force-pushed
the
master
branch
4 times, most recently
from
8c05dac to
4a6edc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit add an explicit check to see if a
globCWL option actually contains a wildcard (and needs to be resolved against the filesystem on the destination location) or if it is just a plain string (and only needs to check for existence in the target location).