Fixed synchronization of multiple recovery workflows #822
+290
−183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #822 +/- ##
==========================================
+ Coverage 73.70% 74.09% +0.38%
==========================================
Files 91 91
Lines 12281 12312 +31
Branches 2158 2161 +3
==========================================
+ Hits 9052 9122 +70
+ Misses 2718 2680 -38
+ Partials 511 510 -1 ☔ View full report in Codecov by Sentry. |
LanderOtto
force-pushed
the
fix/ft-sync
branch
from
e99fa5b to
96ef0cc
Compare
LanderOtto
force-pushed
the
fix/ft-sync
branch
2 times, most recently
from
76e1c31 to
3c91bed
Compare
LanderOtto
force-pushed
the
fix/ft-sync
branch
from
3c91bed to
7f85ef4
Compare
GlassOfWhiskey
force-pushed
the
master
branch
7 times, most recently
from
b21f362 to
e7820f1
Compare
# Conflicts: # streamflow/recovery/utils.py # tests/test_recovery.py
GlassOfWhiskey
force-pushed
the
master
branch
4 times, most recently
from
8c05dac to
4a6edc9
Compare
# Conflicts: # streamflow/recovery/policy/recovery.py # streamflow/recovery/utils.py
LanderOtto
force-pushed
the
fix/ft-sync
branch
from
2393618 to
d536040
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the synchronization of multiple recovery workflows. An error could occur when a dependent recovery workflow attempted to attach to an
InterWorkflowPortof the dependee recovery workflow, due to the existence of the basePortinstance instead of the expectedInterWorkflowPort(which is created at a later stage of the dependee).