Skip to content

Remove forms-api task from review apps#2243

Merged
stephencdaly merged 1 commit intomainfrom
remove-api-from-review-apps
Sep 26, 2025
Merged

Remove forms-api task from review apps#2243
stephencdaly merged 1 commit intomainfrom
remove-api-from-review-apps

Conversation

@stephencdaly
Copy link
Contributor

@stephencdaly stephencdaly commented Sep 25, 2025

What problem does this pull request solve?

Trello card: https://trello.com/c/YWJAZ2A9/2499-remove-forms-api-from-review-apps

Forms-admin no longer makes requests to forms-api, so we no longer need to create the forms-api container as part of the review-apps deployment.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@stephencdaly stephencdaly force-pushed the remove-api-from-review-apps branch from b2ddd68 to ecf6b9c Compare September 25, 2025 13:54
@stephencdaly stephencdaly force-pushed the remove-api-from-review-apps branch from ecf6b9c to 6fae996 Compare September 25, 2025 14:03
@stephencdaly stephencdaly marked this pull request as draft September 25, 2025 16:40
@stephencdaly stephencdaly marked this pull request as ready for review September 25, 2025 16:40
@stephencdaly stephencdaly force-pushed the remove-api-from-review-apps branch from 6fae996 to a9af252 Compare September 26, 2025 09:22
Forms-admin no longer makes requests to forms-api, so we no longer
need to create the forms-api container as part of the review-apps
deployment.
@stephencdaly stephencdaly force-pushed the remove-api-from-review-apps branch from a9af252 to 67ba7b2 Compare September 26, 2025 10:23
@sonarqubecloud
Copy link

@github-actions
Copy link

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2243.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@stephencdaly stephencdaly merged commit 255f96f into main Sep 26, 2025
7 checks passed
@stephencdaly stephencdaly deleted the remove-api-from-review-apps branch September 26, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants