Conversation
chao-xian
left a comment
There was a problem hiding this comment.
Looks good and work on the review app
DavidBiddle
left a comment
There was a problem hiding this comment.
Code looks good, tested locally and it all works with the migration task and looks as expected on the live/archived and Welsh pages 🎉
0221a23 to
544ef2e
Compare
Change the declaration page to use the Markdown editor and the declaration_markdown field instead of a text area and declaration_text.
The view of a live form show show the declaration_markdown instead of the declaration_text.
The declaration markdown preview should show the new text when there is no content to preview.
544ef2e to
aecef3e
Compare
|
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2620.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |



Switch declarations to markdown not text
Trello card: https://trello.com/c/b8rdhhe4/2836-support-markdown-in-declaration-field
This PR switches to using the markdown editors for declarations in English and Welsh.
The
forms:convert_declaration_text_to_markdownhas been run in dev, prod and staging and the runner is displaying the declaration_markdown field.This PR stops using the original field,
declaration_textand only uses declaration_markdown.delcaration_textis not dropped from the database or form documents. This allows rollback and also re-running theforms:convert_declaration_text_to_markdownif for some reason we need to.The
declaration_textfield can be ignored and dropped and field removed from form_documents in a future, cleanup PR.Things to consider when reviewing