Revert "Merge pull request #1119 from alphagov/ldeb-add-feature-flag-branching#1325
Merged
thomasiles merged 1 commit intomainfrom Jan 30, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the changes to add the feature flag for branch_routing
The feature flag was used to enable the feature in the dev environment and delay releasing into prod.
We have deployed changes to how the feature flag works which allow it to be enabled for some groups only.
This revert removes setting the feature flag so that it will fall back to the default found in the settings file, which is to look at groups for the source of the feature.
This will mean branch_routing will no longer be enabled on all groups in the dev environment.
This reverts commit 2c06fe4, reversing changes made to e93aa4f.
What problem does this pull request solve?
Trello card:
Things to consider when reviewing
Reminders
If you've made changes to the deployer role (files in
modules/deployer-access):make <environment> forms/account applyon the relevant environments (dev,staging,user-research, and/orprod)apply-forms-terraform-<environment>pipelines have run successfully