Skip to content

Revert "Merge pull request #1119 from alphagov/ldeb-add-feature-flag-branching#1325

Merged
thomasiles merged 1 commit intomainfrom
revert-add-branch_routing-feature-flag
Jan 30, 2025
Merged

Revert "Merge pull request #1119 from alphagov/ldeb-add-feature-flag-branching#1325
thomasiles merged 1 commit intomainfrom
revert-add-branch_routing-feature-flag

Conversation

@thomasiles
Copy link
Copy Markdown
Contributor

This PR reverts the changes to add the feature flag for branch_routing

The feature flag was used to enable the feature in the dev environment and delay releasing into prod.

We have deployed changes to how the feature flag works which allow it to be enabled for some groups only.

This revert removes setting the feature flag so that it will fall back to the default found in the settings file, which is to look at groups for the source of the feature.

This will mean branch_routing will no longer be enabled on all groups in the dev environment.

This reverts commit 2c06fe4, reversing changes made to e93aa4f.

What problem does this pull request solve?

Trello card:

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

Reminders

If you've made changes to the deployer role (files in modules/deployer-access):

  • Remember to run make <environment> forms/account apply on the relevant environments (dev, staging, user-research, and/or prod)
  • Check the #govuk-forms-deployment-notifications Slack channel to ensure the apply-forms-terraform-<environment> pipelines have run successfully

…branching"

This reverts commit 2c06fe4, reversing
changes made to e93aa4f.
Copy link
Copy Markdown
Member

@lfdebrux lfdebrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thomasiles thomasiles merged commit 5bfbb7c into main Jan 30, 2025
@thomasiles thomasiles deleted the revert-add-branch_routing-feature-flag branch January 30, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants