Remove CodeBuild runner infrastructure#1959
Draft
whi-tw wants to merge 2 commits intowhi-tw/allow-github-hosted-runner-deploy-review-appsfrom
Draft
Remove CodeBuild runner infrastructure#1959whi-tw wants to merge 2 commits intowhi-tw/allow-github-hosted-runner-deploy-review-appsfrom
whi-tw wants to merge 2 commits intowhi-tw/allow-github-hosted-runner-deploy-review-appsfrom
Conversation
whi-tw
force-pushed
the
whi-tw/allow-github-hosted-runner-deploy-review-apps
branch
from
e120964 to
7d50b62
Compare
whi-tw
force-pushed
the
whi-tw/stop-using-self-hosted-runners
branch
from
c42672a to
6b71efd
Compare
whi-tw
force-pushed
the
whi-tw/allow-github-hosted-runner-deploy-review-apps
branch
from
7d50b62 to
5928f55
Compare
whi-tw
force-pushed
the
whi-tw/stop-using-self-hosted-runners
branch
from
6b71efd to
2fd54c2
Compare
whi-tw
force-pushed
the
whi-tw/allow-github-hosted-runner-deploy-review-apps
branch
from
5928f55 to
039a9ad
Compare
whi-tw
force-pushed
the
whi-tw/stop-using-self-hosted-runners
branch
from
2fd54c2 to
b77f2b3
Compare
whi-tw
force-pushed
the
whi-tw/allow-github-hosted-runner-deploy-review-apps
branch
from
039a9ad to
7c4ad50
Compare
whi-tw
force-pushed
the
whi-tw/stop-using-self-hosted-runners
branch
from
b77f2b3 to
54ca9c3
Compare
whi-tw
force-pushed
the
whi-tw/allow-github-hosted-runner-deploy-review-apps
branch
2 times, most recently
from
3d65d7b to
f8f2138
Compare
whi-tw
force-pushed
the
whi-tw/stop-using-self-hosted-runners
branch
2 times, most recently
from
aa0eb1c to
889dd66
Compare
whi-tw
force-pushed
the
whi-tw/allow-github-hosted-runner-deploy-review-apps
branch
from
f8f2138 to
cff1352
Compare
Instead of giving GitHub Actions direct access to deploy review apps to ECS, we set up CodeBuild projects that GitHub Actions can trigger via OIDC. This reduces the permissions granted to GitHub Actions, as they no longer need direct access to ECS, ECR, and other resources.
whi-tw
force-pushed
the
whi-tw/allow-github-hosted-runner-deploy-review-apps
branch
from
cff1352 to
1436189
Compare
Remove the CodeBuild-hosted GitHub Actions runner infrastructure now that review apps use GitHub-hosted runners with OIDC authentication. The gha-runner module and CodeBuild resources are no longer needed.
whi-tw
force-pushed
the
whi-tw/stop-using-self-hosted-runners
branch
from
889dd66 to
752c11c
Compare
whi-tw
force-pushed
the
whi-tw/allow-github-hosted-runner-deploy-review-apps
branch
from
1436189 to
ee2195e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/UIEQ97bl/792-stop-using-self-hosted-runners-on-github
Remove the CodeBuild-hosted GitHub Actions runner infrastructure now that review apps use GitHub-hosted runners with OIDC authentication.
The gha-runner module and CodeBuild resources are no longer needed. The data source and service-linked role for app autoscaling are retained in service_linked_roles.tf as they're still used by the review app deployments.
This should not be merged until we've migrated all the app repos, and rebased WIP branches (or at least informed developers of the change so they can rebase)
Things to consider when reviewing
Reminders
If you've made changes to the deployer role (files in
modules/deployer-access):make <environment> forms/account applyon the relevant environments (dev,staging,user-research, and/orprod)apply-forms-terraform-<environment>pipelines have run successfully