Skip to content

Use rebrand feature flag#1422

Closed
chao-xian wants to merge 8 commits intomainfrom
use-rebrand-feature-flag
Closed

Use rebrand feature flag#1422
chao-xian wants to merge 8 commits intomainfrom
use-rebrand-feature-flag

Conversation

@chao-xian
Copy link
Contributor

What problem does this pull request solve?

Trello card:

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@chao-xian chao-xian force-pushed the use-rebrand-feature-flag branch from 5a42f1c to 673794c Compare May 20, 2025 13:04
@chao-xian chao-xian force-pushed the use-rebrand-feature-flag branch from 36a9aed to 6ec7359 Compare May 20, 2025 14:51
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

🎉 A review copy of this PR has been deployed! It is made of up two components

  1. A review copy of forms-runner
  2. A production copy of forms-admin

Important

Not all of the functionality of forms-runner is present in review apps.
Functionality such as sending emails, file upload, and S3 submission types are
deliberately disabled for the sake of simplifying review apps.

You should use the full dev environment to test the functionality which is disabled here.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

Comment on lines +16 to +17
<%# TODO: add crown SVG to footer %>
<%# To do that, we'll either need an update to govuk-components to apply the crown automatically, or we can replace the component with HTML and add the crown ourselves %>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added here and is available in 5.10.0b2.

@chao-xian chao-xian closed this May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants