Update configuration for API requests#1653
Conversation
We have switched our deployed versions of forms-runner to make requests to the forms-admin API endpoints through the internal load balancer rather than to forms-api by setting this environment variable for the ECS tasks. Default the local configuration to make requests to forms-admin rather than forms-api to match the deployed configuration. Because we need to use the hostname for the internal load balancer in the deployed environments, we need to keep a separate setting for this URL to the `forms_admin.base_url` setting which is used to construct links to the admin interface. We may want to consider renaming this setting in future to make it not refer to forms-api.
forms-admin does not require an API key for requests as the /api/ endpoints are only accessible from within the VPC in our deployed environments. Stop sending the API key with requests and remove the configuration setting as forms-runner now makes requests to forms-admin rather than forms-api.
stephencdaly
force-pushed
the
update-api-configuration
branch
from
2401c9e to
ae1dcc4
Compare
|
|
🎉 A review copy of this PR has been deployed! It is made of up two components Important Not all of the functionality of forms-runner is present in review apps. You should use the full dev environment to test the functionality which is disabled here. It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
2 participants
What problem does this pull request solve?
Trello card: https://trello.com/c/AiSEhwAu
Update configuration to talk to forms-admin rather than forms-api locally.
Stop sending the API key with requests and remove the configuration setting as forms-runner now makes requests to forms-admin rather than forms-api.
forms-admin does not require an API key for requests as the /api/ endpoints are only accessible from within the VPC in our deployed environments.
Things to consider when reviewing