Skip to content

Remove reference to forms-api from review apps README#1664

Merged
lfdebrux merged 1 commit intomainfrom
ldeb-remove-forms-api
Oct 1, 2025
Merged

Remove reference to forms-api from review apps README#1664
lfdebrux merged 1 commit intomainfrom
ldeb-remove-forms-api

Conversation

@lfdebrux
Copy link
Member

@lfdebrux lfdebrux commented Oct 1, 2025

What problem does this pull request solve?

This was missed from PR #1654.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@lfdebrux lfdebrux requested a review from stephencdaly October 1, 2025 12:02
@lfdebrux lfdebrux enabled auto-merge October 1, 2025 12:02
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

🎉 A review copy of this PR has been deployed! It is made of up two components

  1. A review copy of forms-runner
  2. A production copy of forms-admin

Important

Not all of the functionality of forms-runner is present in review apps.
Functionality such as sending emails, file upload, and S3 submission types are
deliberately disabled for the sake of simplifying review apps.

You should use the full dev environment to test the functionality which is disabled here.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

Copy link
Contributor

@stephencdaly stephencdaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this

@lfdebrux lfdebrux merged commit 9030559 into main Oct 1, 2025
12 checks passed
@lfdebrux lfdebrux deleted the ldeb-remove-forms-api branch October 1, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants