Skip to content

Small refactor to logging for send submission job#1757

Draft
lfdebrux wants to merge 3 commits intomainfrom
ldeb-refactor-send-submission-job-logging
Draft

Small refactor to logging for send submission job#1757
lfdebrux wants to merge 3 commits intomainfrom
ldeb-refactor-send-submission-job-logging

Conversation

@lfdebrux
Copy link
Member

@lfdebrux lfdebrux commented Nov 26, 2025

What problem does this pull request solve?

  • Use same time for delivery attempt in submission record and metrics
  • Rename submission_email_sent event to submission_sent

See commits for more details.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@lfdebrux lfdebrux force-pushed the ldeb-refactor-send-submission-job-logging branch from a4c8dfd to 0d9be1e Compare November 27, 2025 08:03
@lfdebrux lfdebrux force-pushed the ldeb-refactor-send-submission-job-logging branch from 0d9be1e to 44dc0a4 Compare December 4, 2025 09:18
@lfdebrux lfdebrux marked this pull request as draft December 12, 2025 08:03
@lfdebrux
Rename submission_email_sent event to submission_sent
191b480 
In future the send submission job could send submissions by methods
other than email, so the name of this event should be more generic.
@lfdebrux
Use same time for delivery attempt in submission record and metrics
28ce3ef
@lfdebrux lfdebrux force-pushed the ldeb-refactor-send-submission-job-logging branch from 44dc0a4 to 4572702 Compare December 18, 2025 13:32
@lfdebrux
Change logging of sent submission to be more like logging of submit
d64caba 
Refactor the `submission_sent` event logging so that it is similar to
the logging of the `submit` event; add a method for it to the
LogEventService, change the event name depending on whether the
submission is for a form preview or not, and log the submission type and
format.
@lfdebrux lfdebrux force-pushed the ldeb-refactor-send-submission-job-logging branch from 4572702 to d64caba Compare December 19, 2025 06:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 19, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

🎉 A review copy of this PR has been deployed! It is made of up two components

  1. A review copy of forms-runner
  2. A production copy of forms-admin

Important

Not all of the functionality of forms-runner is present in review apps.
Functionality such as sending emails, file upload, and S3 submission types are
deliberately disabled for the sake of simplifying review apps.

You should use the full dev environment to test the functionality which is disabled here.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lfdebrux